Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/{start,init}: ensure `cockroach init` always errors on ready clusters #37399

Merged
merged 1 commit into from May 9, 2019

Conversation

4 participants
@knz
Copy link
Member

commented May 8, 2019

Release note (bug fix): cockroach init will now always properly
report when a cluster is already initialized, even after the node that
it's connecting to is restarted.

@knz knz requested a review from andreimatei May 8, 2019

@knz knz requested review from cockroachdb/cli-prs as code owners May 8, 2019

@knz knz added this to To do in Command Line Interface (CLI) via automation May 8, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 8, 2019

This change is Reviewable

cli/{start,init}: ensure `cockroach init` always errors on ready clus…
…ters

Release note (bug fix): `cockroach init` will now always properly
report when a cluster is already initialized, even after the node that
it's connecting to is restarted.

@knz knz force-pushed the knz:20190507-cli-init branch from a265a3c to d4d931f May 8, 2019

@tbg

tbg approved these changes May 9, 2019

@andreimatei
Copy link
Member

left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)

@knz

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

TFYRs!

bors r+

craig bot pushed a commit that referenced this pull request May 9, 2019

Merge #37399
37399: cli/{start,init}: ensure `cockroach init` always errors on ready clusters r=knz a=knz

Release note (bug fix): `cockroach init` will now always properly
report when a cluster is already initialized, even after the node that
it's connecting to is restarted.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig

This comment has been minimized.

Copy link

commented May 9, 2019

Build succeeded

@craig craig bot merged commit d4d931f into cockroachdb:master May 9, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

Command Line Interface (CLI) automation moved this from To do to Done May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.