Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partitionccl: error instead of panic for an invalid partitioning #37689

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
4 participants
@danhhz
Copy link
Contributor

commented May 21, 2019

If a PARTITION BY LIST both didn't match the column names in the index
being partitioned and also tried to partition by more columns than were
in the index, we previously panic'd when constructing the error.

Closes #37682

Release note (bug fix): Fixed a panic when construting the error message
for an invalid partitioning.

partitionccl: error instead of panic for an invalid partitioning
If a PARTITION BY LIST both didn't match the column names in the index
being partitioned and also tried to partition by more columns than were
in the index, we previously panic'd when constructing the error.

Closes #37682

Release note (bug fix): Fixed a panic when construting the error message
for an invalid partitioning.

@danhhz danhhz requested review from jordanlewis and justinj May 21, 2019

@danhhz danhhz requested a review from cockroachdb/sql-ccl-prs as a code owner May 21, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 21, 2019

This change is Reviewable

@justinj
Copy link
Member

left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @justinj)

@jordanlewis
Copy link
Member

left a comment

LGTM, thank you Dan!

@danhhz

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

TFTRs!

bors r=justinj,jordanlewis

craig bot pushed a commit that referenced this pull request May 21, 2019

Merge #37673 #37689
37673: roachtest: skip kv/gracefuldraining r=nvanbenschoten a=tbg

I should've done this a long time ago, it's been flaky for five months
and failed approximately 120 times (i.e. most of the time).

See #33501 (comment)

Release note: None

37689: partitionccl: error instead of panic for an invalid partitioning r=justinj,jordanlewis a=danhhz

If a PARTITION BY LIST both didn't match the column names in the index
being partitioned and also tried to partition by more columns than were
in the index, we previously panic'd when constructing the error.

Closes #37682

Release note (bug fix): Fixed a panic when construting the error message
for an invalid partitioning.

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 21, 2019

Build succeeded

@craig craig bot merged commit d81dfec into cockroachdb:master May 21, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:part_error branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.