Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload/movr: initial implementation of MovR workload.Generator #37709

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
3 participants
@danhhz
Copy link
Contributor

commented May 21, 2019

This is a partial port of the cockroachdb/movr project to a
workload.Generator to enable easier large-scale testing (and integration
with our cli commands, like cockroach demo). Only the initial data
load is supported for now; use the official MovR port for queryload.

Release note: None

@danhhz danhhz requested a review from nstewart May 21, 2019

@danhhz danhhz requested review from cockroachdb/cli-prs as code owners May 21, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 21, 2019

This change is Reviewable

@danhhz

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@nstewart I could keep going on making this more exactly match the reference impl, but I was thinking that this might be close enough to be mergeable. Then we can do any fixes (the dates and times are a little different and maybe we could port a small bit of the faker lib) as incremental improvements. Thoughts?

@nstewart

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Can you add a release note cc @jseldess

@nstewart

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

LGTM -- I can test it with the movr image and provide feedback on master

@danhhz danhhz force-pushed the danhhz:workload_movr branch from 9c24ef2 to a50fa37 May 24, 2019

@danhhz

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Thanks for the review!

bors r=nstewart

craig bot pushed a commit that referenced this pull request May 24, 2019

Merge #37709
37709: workload/movr: initial implementation of MovR workload.Generator r=nstewart a=danhhz

This is a partial port of the cockroachdb/movr project to a
workload.Generator to enable easier large-scale testing (and integration
with our cli commands, like `cockroach demo`). Only the initial data
load is supported for now; use the official MovR port for queryload.

Release note: None

Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 24, 2019

Build failed

workload/movr: initial implementation of MovR workload.Generator
This is a partial port of the cockroachdb/movr project to a
workload.Generator to enable easier large-scale testing (and integration
with our cli commands, like `cockroach demo`). Only the initial data
load is supported for now; use the official MovR port for queryload.

Release note (cli change): Add the `movr` workload generator, simulating
a fictional ride sharing company.

@danhhz danhhz force-pushed the danhhz:workload_movr branch from a50fa37 to eac3e69 May 24, 2019

@danhhz

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Resolved merge conflict

bors r=nstewart

craig bot pushed a commit that referenced this pull request May 24, 2019

Merge #37709
37709: workload/movr: initial implementation of MovR workload.Generator r=nstewart a=danhhz

This is a partial port of the cockroachdb/movr project to a
workload.Generator to enable easier large-scale testing (and integration
with our cli commands, like `cockroach demo`). Only the initial data
load is supported for now; use the official MovR port for queryload.

Release note: None

Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 24, 2019

Build succeeded

@craig craig bot merged commit eac3e69 into cockroachdb:master May 24, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:workload_movr branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.