Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Address inet casting roundtrip issue #37938

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
3 participants
@rohany
Copy link
Contributor

commented May 30, 2019

Address a small issue brought up in #32876, where conversion of an inet into a string, and back into an inet would fail.

@rohany rohany requested a review from solongordon May 30, 2019

@rohany rohany requested a review from cockroachdb/sql-rest-prs as a code owner May 30, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 30, 2019

This change is Reviewable

@solongordon
Copy link
Contributor

left a comment

:lgtm: (once the commits are squashed). But this doesn't address the original issue brought up in #32876, right?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @solongordon)

@rohany

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

no, the issue with the values command still remains, this fixes jordan's comment in the issues.

@rohany rohany force-pushed the rohany:ipaddr_issue branch from 6e8fb57 to 00d0143 May 30, 2019

rohany added a commit to rohany/cockroach that referenced this pull request May 30, 2019

sql: Fixed roundtrip typecasting issue with inets
Fixes an issue brought up in cockroachdb#37938, but does not resolve the entire
issue.

Release note (sql change): Fix a roundtrip typecasting issue where
an inet casted to a string and back to an inet would fail.

@rohany rohany force-pushed the rohany:ipaddr_issue branch from 00d0143 to 547cfc7 May 30, 2019

rohany added a commit to rohany/cockroach that referenced this pull request May 30, 2019

sql: Fixed roundtrip typecasting issue with inets
Fixes an issue brought up in cockroachdb#37938, but does not resolve the entire
issue.

Release note (sql change): Fix a roundtrip typecasting issue where
an inet casted to a string and back to an inet would fail.
sql: Fixed roundtrip typecasting issue with inets
Fixes an issue brought up in #37938, but does not resolve the entire
issue.

Release note (sql change): Fix a roundtrip typecasting issue where
an inet casted to a string and back to an inet would fail.

@rohany rohany force-pushed the rohany:ipaddr_issue branch from 547cfc7 to b3f2f94 May 30, 2019

@rohany

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

bors r+

craig bot pushed a commit that referenced this pull request May 30, 2019

Merge #37938
37938: sql: Address inet casting roundtrip issue r=rohany a=rohany

Address a small issue brought up in #32876, where conversion of an inet into a string, and back into an inet would fail. 

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
@rohany

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

bors r+

craig bot pushed a commit that referenced this pull request Jun 3, 2019

Merge #37938
37938: sql: Address inet casting roundtrip issue r=rohany a=rohany

Address a small issue brought up in #32876, where conversion of an inet into a string, and back into an inet would fail. 

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
@craig

This comment has been minimized.

Copy link

commented Jun 3, 2019

Build succeeded

@craig craig bot merged commit b3f2f94 into cockroachdb:master Jun 3, 2019

5 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - Gopkg.lock (tim) No manifest changes detected
security/snyk - pkg/ui/package.json (tim) No manifest changes detected

asubiotto added a commit to asubiotto/cockroach that referenced this pull request Jun 4, 2019

sql: Fixed roundtrip typecasting issue with inets
Fixes an issue brought up in cockroachdb#37938, but does not resolve the entire
issue.

Release note (sql change): Fix a roundtrip typecasting issue where
an inet casted to a string and back to an inet would fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.