Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cli: fix use of IPv6 addresses with RPC client commands #37977
(This was actually a regression of my doing, back from #28373. Didn't pick it up back then because we didn't have a test.)
Release note (bug fix): the
andreimatei left a comment
Do y'all know if we could have routable ipv6 in roachprod? Then we could migrate some random roachtest to ipv6 to exercise this fix (right?)
I don't like this "example" very much. It's not really what examples are supposed to be used for. Also particularly the reference to the bug seems click bait. Also I thought this would not work on TC?
How about just writing a unit test for the
knz left a comment
Yeah I was trying this out to see how TC would respond. That's how I found TC didn't like it.
Yep, that's the better idea. Done.