Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: makes MakeCollatedString allow oid.T_name. #39682

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@hueypark
Copy link
Contributor

hueypark commented Aug 15, 2019

Fixes #39654.

Release note: None

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Aug 15, 2019

This change is Reviewable

Copy link
Member

mjibson left a comment

This needs a test.

Fix: #39654

Release note: None
@hueypark hueypark force-pushed the hueypark:allow-tname branch from b141b6d to bc83130 Aug 15, 2019
@hueypark

This comment has been minimized.

Copy link
Contributor Author

hueypark commented Aug 15, 2019

@mjibson
Thank you for your review.
I added the necessary test now.

@jordanlewis

This comment has been minimized.

Copy link
Member

jordanlewis commented Aug 19, 2019

LGTM. Thank you @hueypark!

@jordanlewis

This comment has been minimized.

Copy link
Member

jordanlewis commented Aug 19, 2019

bors r+

craig bot pushed a commit that referenced this pull request Aug 19, 2019
39682: sql: makes MakeCollatedString allow oid.T_name. r=jordanlewis a=hueypark

Fixes #39654.

Release note: None

Co-authored-by: Jaewan Park <jaewan.huey.park@gmail.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Aug 19, 2019

Build succeeded

@craig craig bot merged commit bc83130 into cockroachdb:master Aug 19, 2019
3 checks passed
3 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.