Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: sql: support EXPLAIN with AS OF SYSTEM TIME #43306

Merged
merged 1 commit into from Dec 18, 2019

Conversation

@RaduBerinde
Copy link
Member

RaduBerinde commented Dec 18, 2019

Backport 1/1 commits from #43296.

/cc @cockroachdb/release


We apparently can't stick an EXPLAIN in front of a query that uses
AOST. The fix is very easy, we need an extra case for the logic that
figures out the statement-wide timestamp.

Note that if we want to do SELECT FROM [EXPLAIN ...], in that case
we still need to add AS OF SYSTEM TIME to the outer clause as usual.

Fixes #43294.

Release note (bug fix): EXPLAIN can now be used with statements that
use AS OF SYSTEM TIME.

We apparently can't stick an `EXPLAIN` in front of a query that uses
AOST. The fix is very easy, we need an extra case for the logic that
figures out the statement-wide timestamp.

Note that if we want to do `SELECT FROM [EXPLAIN ...]`, in that case
we still need to add AS OF SYSTEM TIME to the outer clause as usual.

Fixes #43294.

Release note (bug fix): EXPLAIN can now be used with statements that
use AS OF SYSTEM TIME.
@RaduBerinde RaduBerinde requested a review from andreimatei Dec 18, 2019
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Dec 18, 2019

This change is Reviewable

@andreimatei

This comment has been minimized.

Copy link
Member

andreimatei commented Dec 18, 2019

@RaduBerinde RaduBerinde merged commit a320577 into cockroachdb:release-2.1 Dec 18, 2019
2 checks passed
2 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@RaduBerinde RaduBerinde deleted the RaduBerinde:backport2.1-43296 branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.