Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.1: jobs: pending jobs should be adoptable #43416

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@spaskob
Copy link
Collaborator

spaskob commented Dec 20, 2019

It's possible that a job is created (so in state pending) but
due to a failure before the job is marked as started it can
be left in pending state. These jobs should be adoptable by
other nodes.

Touches #43375.

Release note (bug fix): this bug may cause jobs to be left indefinitely
in pending state and never run.

It's possible that a job is created (so in state pending) but
due to a failure before the job is marked as started it can
be left in pending state. These jobs should be adoptable by
other nodes.

Touches #43375.

Release note (bug fix): this bug may cause jobs to be left indefinitely
in pending state and never run.
@spaskob spaskob requested review from rytaft and cockroachdb/release Dec 20, 2019
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Dec 20, 2019

This change is Reviewable

@spaskob

This comment has been minimized.

Copy link
Collaborator Author

spaskob commented Dec 20, 2019

This is original work on 19.1 since backporting #42880 was too cumbersome due to merge conflicts.

@rytaft
rytaft approved these changes Dec 20, 2019
Copy link
Contributor

rytaft left a comment

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rytaft

This comment has been minimized.

Copy link
Contributor

rytaft commented Dec 20, 2019

[nit] update the title of the PR message to include release-19.1

@spaskob spaskob changed the title jobs: pending jobs should be adoptable release-19.1: jobs: pending jobs should be adoptable Dec 20, 2019
@spaskob spaskob merged commit a85a9a4 into cockroachdb:release-19.1 Dec 20, 2019
2 checks passed
2 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.