Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.1: sql: convert locale panic to error #44119

Merged

Conversation

@RaduBerinde
Copy link
Member

RaduBerinde commented Jan 17, 2020

Backport 1/1 commits from #44103. This required a lot of manual merging, would be useful to look over the diff again.

/cc @cockroachdb/release


We have seen cases where the locale fails to parse when we create a
NewDCollatedString. We can't reproduce and root cause but we can at
least convert it to an internal error.

Informs #35722.

Release note (bug fix): Converted a panic in
golang.org/x/text/language/tags.go when using collated strings to an
error.

@RaduBerinde RaduBerinde requested a review from knz Jan 17, 2020
@RaduBerinde RaduBerinde requested a review from cockroachdb/sql-opt-prs as a code owner Jan 17, 2020
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Jan 17, 2020

This change is Reviewable

@knz
knz approved these changes Jan 17, 2020
We have seen cases where the locale fails to parse when we create a
`NewDCollatedString`. We can't reproduce and root cause but we can at
least convert it to an internal error.

Informs #35722.

Release note (bug fix): Converted a panic in
golang.org/x/text/language/tags.go when using collated strings to an
error.
@RaduBerinde RaduBerinde force-pushed the RaduBerinde:backport19.1-44103 branch from fd7543c to 1fcbc4e Jan 17, 2020
@RaduBerinde RaduBerinde merged commit a8444e2 into cockroachdb:release-19.1 Jan 18, 2020
2 checks passed
2 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@RaduBerinde RaduBerinde deleted the RaduBerinde:backport19.1-44103 branch Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.