Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: colexec: fix negative substring length error propagation #44629

Merged
merged 1 commit into from Feb 2, 2020

Conversation

@yuzefovich
Copy link
Contributor

yuzefovich commented Feb 2, 2020

Backport 1/1 commits from #44627.

/cc @cockroachdb/release


We were incorrectly using VectorizedInternalPanic to propagate the
negative substring length error.

Fixes: #44625.

Release note (bug fix): Previously, CockroachDB would return an internal
error when substring function with a negative length was executed via
the vectorized engine, and this has been fixed (now it returns a regular
query error).

We were incorrectly using `VectorizedInternalPanic` to propagate the
negative substring length error.

Release note (bug fix): Previously, CockroachDB would return an internal
error when `substring` function with a negative length was executed via
the vectorized engine, and this has been fixed (now it returns a regular
query error).
@yuzefovich yuzefovich requested a review from rohany Feb 2, 2020
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Feb 2, 2020

This change is Reviewable

@rohany

This comment has been minimized.

Copy link
Contributor

rohany commented Feb 2, 2020

lgtm

@yuzefovich yuzefovich merged commit 4c97816 into cockroachdb:release-19.2 Feb 2, 2020
3 checks passed
3 checks passed
Commit Message Lint Pull request title and commit message format are not configured
Details
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@yuzefovich yuzefovich deleted the yuzefovich:backport19.2-44627 branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.