Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: tree: fix type checking error with `BETWEEN` #44810

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@rohany
Copy link
Contributor

rohany commented Feb 6, 2020

Backport 1/1 commits from #44775.

/cc @cockroachdb/release


Part of #44148.

This PR fixes a bug in typechecking where the
boundaries of a BETWEEN clause could be of
a different type, but the typechecking would
succeed if the candidate expression was NULL.

Release note (bug fix): This PR fixes a typechecking
error where BETWEEN would sometimes allow boundary
expressions of a different type.

Part of #44148.

This PR fixes a bug in typechecking where the
boundaries of a `BETWEEN` clause could be of
a different type, but the typechecking would
succeed if the candidate expression was NULL.

Release note (bug fix): This PR fixes a typechecking
error where `BETWEEN` would sometimes allow boundary
expressions of a different type.
@rohany rohany requested a review from knz Feb 6, 2020
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Feb 6, 2020

This change is Reviewable

@knz
knz approved these changes Feb 6, 2020
@rohany rohany merged commit a084abf into cockroachdb:release-19.2 Feb 6, 2020
3 checks passed
3 checks passed
Commit Message Lint Pull request title and commit message format are not configured
Details
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.