Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: colexec: disallow planning CASE operators with unknown WHEN type #44818

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@asubiotto
Copy link
Contributor

asubiotto commented Feb 6, 2020

Backport 1/1 commits from #44756.

/cc @cockroachdb/release


Release note (bug fix): When vectorize=experimental_on, CASE operators with an
unknown WHEN type fall back to row execution.

Fixes #44726

These will fall back to row execution.

Release note (bug fix): CASE operators with an unknown WHEN type no longer
return an error.
@asubiotto asubiotto requested review from yuzefovich and cockroachdb/vectorize Feb 6, 2020
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Feb 6, 2020

This change is Reviewable

@asubiotto

This comment has been minimized.

Copy link
Contributor Author

asubiotto commented Feb 6, 2020

Slight conflict when backporting, might be good to take a closer look

Copy link
Contributor Author

asubiotto left a comment

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @yuzefovich)


pkg/sql/colexec/execplan.go, line 1254 at r1 (raw file):

			whenColType := typeconv.FromColumnType(whenResolvedType)
			if whenColType == coltypes.Unhandled {
				return nil, resultIdx, ct, memUsed, errors.Newf(

Is it cool to return memUsed here? or should it be 0? I see both in this code

Copy link
Contributor

yuzefovich left a comment

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)


pkg/sql/colexec/execplan.go, line 1254 at r1 (raw file):

Previously, asubiotto (Alfonso Subiotto Marqués) wrote…

Is it cool to return memUsed here? or should it be 0? I see both in this code

It doesn’t matter, any option is fine.

@asubiotto asubiotto merged commit eb88373 into cockroachdb:release-19.2 Feb 6, 2020
3 checks passed
3 checks passed
Commit Message Lint Pull request title and commit message format are not configured
Details
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@asubiotto asubiotto deleted the asubiotto:backport19.2-44756 branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.