delegate: fix SHOW INDEXES ... WITH COMMENT showing extraneous data #46621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otan
added this to Open PRs
in SQL Features (Deprecated - use SQL Experience board)
via automation
|
This change is |
|
LGTM looks like we've had broken tests for this just sitting around in the repo. |
Resolves cockroachdb#46333 Release justification: low risk, high benefit changes to existing functionality Release note (bug fix): Previously, SHOW INDEXES ... WITH COMMENT would show duplicate rows for certain tables if indexes were identically named. This has been fixed.
|
the power of "-rewrite" very powerful hehe bors r=rohany |
Build failed (retrying...) |
Build failed (retrying...) |
Build succeeded |
SQL Features (Deprecated - use SQL Experience board)
automation
moved this from Open PRs
to Done
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46333
Release justification: low risk, high benefit changes to existing
functionality
Release note (bug fix): Previously, SHOW INDEXES ... WITH COMMENT would
show duplicate rows for certain tables if indexes were identically
named. This has been fixed.