cli: disable block profiling by default #48133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable block profiles by default as they consume a small but measurable
amount of CPU: 1.5% of CPU in one tpcc experiment. Additionally, block
profiling affects Pebble more than RocksDB as RocksDB's synchronization
primitives are invisible to the Go runtime. This levels the playing
field.
Release note (performance improvement): Disable the Go runtime block
profile by default which results in a small but measurable reduction in
CPU usage. The block profile has diminished in utility with the advent
of mutex contention profiles and is almost never used during performance
investigations.