opt: improve the rule that converts COUNT to COUNT_ROWS #49126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Improve the ConvertCountToCountRows rule to check for any scalar expression that is never null, not just bare variable references. Release note (performance improvement): `COUNT` is now converted to `COUNT(*)` (aka `COUNT_ROWS`) in more cases.
RaduBerinde
force-pushed
the
count-to-count-rows
branch
from
9821126
to
7d80364
Compare
maddyblue
approved these changes
May 18, 2020
rytaft
approved these changes
May 18, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
RaduBerinde
commented
May 18, 2020
There was a problem hiding this comment.
bors r+
Reviewable status:
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the ConvertCountToCountRows rule to check for any scalar expression that
is never null, not just bare variable references.
Release note (performance improvement):
COUNTis now converted toCOUNT(*)(aka
COUNT_ROWS) in more cases.