release-19.2: sql: allow pgwire auth methods to specify a cleanup func #49655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On connection close, some auth methods may need to cleanup resources. Add a callback for that. This fixes a bug in the GSS auth method where replay cache file descriptors were incorrectly kept open after connection close because the context was not being deleted. Release note (bug fix): stop leaking file descriptors during GSS authentication.
|
This change is |
knz
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #49572.
/cc @cockroachdb/release
On connection close, some auth methods may need to cleanup resources. Add
a callback for that.
This fixes a bug in the GSS auth method where replay cache file
descriptors were incorrectly kept open after connection close because
the context was not being deleted.
Release note (bug fix): stop leaking file descriptors during GSS
authentication.