Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_IsEmpty and ST_IsCollection #53217

Merged
merged 1 commit into from Aug 21, 2020

Conversation

erikgrinaker
Copy link
Contributor

ST_IsCollection does not handle geopb.ShapeType_Geometry in any special way, and will always return false - is this sufficient?

Release note (sql change): Implement the geometry builtins ST_IsEmpty
and ST_IsCollection.

Closes #48954.
Closes #48955.

Release note (sql change): Implement the geometry builtins `ST_IsEmpty`
and `ST_IsCollection`.
@blathers-crl
Copy link

blathers-crl bot commented Aug 21, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Aug 21, 2020
@blathers-crl blathers-crl bot requested a review from otan August 21, 2020 17:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
Copy link
Contributor

otan commented Aug 21, 2020

ST_IsCollection does not handle geopb.ShapeType_Geometry in any special way, and will always return false - is this sufficient?

ShapeType_Geometry is never returned so we should be ok!

@erikgrinaker
Copy link
Contributor Author

I'm guessing the test failure is an unrelated non-deterministic failure, would you mind rerunning it @otan?

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's not you. i could re-run it, but bors will do it for me.

thank you again!

@otan
Copy link
Contributor

otan commented Aug 21, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 21, 2020

Build succeeded:

@craig craig bot merged commit cab0b31 into cockroachdb:master Aug 21, 2020
@erikgrinaker erikgrinaker deleted the simple-predicates branch March 19, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_IsEmpty({geometry}) geo/geomfn: implement ST_IsCollection({geometry})
3 participants