jobs: tiny improvement to error handling

[jordanlewis]

Closes #56999

Release note: None

[cockroach-teamcity]

This change is 

[postamar]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @knz)

---

pkg/jobs/adopt.go, line 312 at r1 (raw file):

					id, s.ID())
			default:
				return errors.AssertionFailedf("unexpected job status %s: %v", job)

Your format string expects two arguments here and you've only provided one. Did you mean statusString, job instead of only job?

[ajwerner]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @knz)

[jordanlewis]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @knz and @postamar)

---

pkg/jobs/adopt.go, line 312 at r1 (raw file):

Previously, postamar (Marius Posta) wrote…

Your format string expects two arguments here and you've only provided one. Did you mean statusString, job instead of only job?

Quite right - fixed.

[postamar]

Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @knz)

[knz]

with nit

Reviewed 2 of 2 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (and 2 stale) (waiting on @jordanlewis)

---

pkg/jobs/adopt.go, line 262 at r2 (raw file):

		// comment this out.
		// if errors.HasAssertionFailure(err) {
		// 	logcrash.ReportOrPanic(ctx, nil, err.Error())

Can you update this comment too?
(ditto the one in deprecated.go)

[jordanlewis]

Hmm, I don't understand those comments. @lucy-zhang?

[thoszhang]

The introduction of the ReportOrPanic calls was originally so that we could have tests crash in contexts where we don't actually want to crash or return errors in production. I commented it out because it was causing test crashes in contexts where we actually wanted failures (IIRC). So if we don't want to call ReportOrPanic anymore, then none of the commented-out lines are relevant anymore and should just be removed.

Reviewed 1 of 2 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (and 2 stale) (waiting on @jordanlewis)

[jordanlewis]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)