importccl: support IMPORT in mixed-version cluster #57382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
reviewed
Dec 3, 2020
pbardea
force-pushed
the
mixed-version-import
branch
from
7d36c2b
to
a5051ab
Compare
pbardea
changed the title
|
I believe that this also fixes #57503. Will add tests. |
pbardea
added
backport-19.2.x
pbardea
force-pushed
the
mixed-version-import
branch
3 times, most recently
from
99a81cc
to
5a15125
Compare
This commit adds support for running IMPORT in a mixed-version cluster. Note, that it does not add support for running an IMPORT during the upgrade of a node however. The IMPORT job would need to be restarted in that case. Release note (sql change): Add support for running IMPORT in a mixed-version cluster.
Before supporting mixed-versions runs of IMPORT this test would fail with: ``` importing fixture: importing table history: pq: version mismatch in flow request: 42; this node accepts 35 through 36 ``` It now succeeds. Note that this test exercises that IMPORT can run in a mixed-version cluster, but not during an upgrade of nodes in the cluster. Release note: None
pbardea
force-pushed
the
mixed-version-import
branch
from
5a15125
to
28487c6
Compare
This commit adds a roachtest that runs an IMPORT on a cluster with a decommissioned node. Release note: None
|
Updated with some roachtests that exercise running import in mixed-version clusters and clusters with a decommissioned node. |
dt
approved these changes
Dec 4, 2020
|
TFTR! |
|
Build succeeded: |
|
It doesn't look like this needs backporting to versions before 20.2. It looks like https://github.com/cockroachdb/cockroach/blob/release-20.1/pkg/sql/distsql_physical_planner.go#L1064 never populates the NodeAddresses map for unhealthy nodes so https://github.com/cockroachdb/cockroach/blob/release-20.1/pkg/sql/distsql_plan_csv.go#L123 just did the right thing before |
pbardea
removed
backport-19.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for running IMPORT in a mixed-version cluster.
Note, that it does not add support for running an IMPORT during the
upgrade of a node however. The IMPORT job would need to be restarted in
that case.
Release note (sql change): Add support for running IMPORT in a
mixed-version cluster.