release-20.2: opt: fix FoldJSONAccessIntoValues corner case #60808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule was inadvertently firing if we had a JSON array with the right keys as elements. Fixes cockroachdb#60522. Release note (bug fix): fixed an internal error caused in some cases involving JSON objects and arrays in a VALUES clause.
|
This change is |
rytaft
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #60767.
/cc @cockroachdb/release
The rule was inadvertently firing if we had a JSON array with the
right keys as elements.
Fixes #60522.
Release note (bug fix): fixed an internal error caused in some cases
involving JSON objects and arrays in a VALUES clause.