sql: adding missing tables on information_schema #65854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
mnovelodou
force-pushed
the
information_schema_new_tables
branch
from
2636ec6
to
e2573d2
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
rafiss
requested changes
Jun 4, 2021
| "MissingColumns": 71, | ||
| "TotalColumns": 280, | ||
| "MissingTables": 0, | ||
| "MissingColumns": 9, |
There was a problem hiding this comment.
what are the 9 missing columns? maybe we could add those too.
There was a problem hiding this comment.
I found an issue from this mysql, which seemed outdated, these are the actual values:
"diffSummary": {
"TotalTables": 48,
"TotalColumns": 280,
"MissingTables": 21,
"MissingColumns": 80,
"DatatypeMismatches": 0
}
e2573d2
to
de86d27
Compare
mnovelodou
force-pushed
the
information_schema_new_tables
branch
2 times, most recently
from
2082e0c
to
f7e8d37
Compare
mnovelodou
force-pushed
the
information_schema_new_tables
branch
from
f7e8d37
to
cb952a2
Compare
rafiss
approved these changes
Jun 18, 2021
Previously, there were 38 undefined information_schema tables that exists in postgres This was inadequate because not having them may cause compatibility issues To address this, this patch defines these 38 tables as unimplemented to allow queries Release note (sql change): adding empty missing tables on information schema for compatibility: attributes check_constraint_routine_usage column_column_usage column_domain_usage column_options constraint_table_usage data_type_privileges domain_constraints domain_udt_usage domains element_types foreign_data_wrapper_options foreign_data_wrappers foreign_server_options foreign_servers foreign_table_options foreign_tables information_schema_catalog_name role_column_grants role_routine_grants role_udt_grants role_usage_grants routine_privileges sql_features sql_implementation_info sql_parts sql_sizing transforms triggered_update_columns triggers udt_privileges usage_privileges user_defined_types user_mapping_options user_mappings view_column_usage view_routine_usage view_table_usage Related to: cockroachdb#8675
mnovelodou
force-pushed
the
information_schema_new_tables
branch
from
cb952a2
to
b0b7bf4
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were 38 undefined information_schema tables that
exists in postgres
This was inadequate because not having them may cause compatibility
issues
To address this, this patch defines these 38 tables as unimplemented
to allow queries
Release note (sql change): adding empty missing tables on information
schema for compatibility:
attributes
check_constraint_routine_usage
column_column_usage
column_domain_usage
column_options
constraint_table_usage
data_type_privileges
domain_constraints
domain_udt_usage
domains
element_types
foreign_data_wrapper_options
foreign_data_wrappers
foreign_server_options
foreign_servers
foreign_table_options
foreign_tables
information_schema_catalog_name
role_column_grants
role_routine_grants
role_udt_grants
role_usage_grants
routine_privileges
sql_features
sql_implementation_info
sql_parts
sql_sizing
transforms
triggered_update_columns
triggers
udt_privileges
usage_privileges
user_defined_types
user_mapping_options
user_mappings
view_column_usage
view_routine_usage
view_table_usage
Related to: #8675