sql implement the pg_db_role_setting table #68245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
pg-db-role-setting
branch
2 times, most recently
from
2f83ad5
to
8ef6d21
Compare
|
what was the nit? |
rafiss
force-pushed
the
pg-db-role-setting
branch
from
8ef6d21
to
0e8b700
Compare
RichardJCai
reviewed
Aug 5, 2021
pkg/sql/pg_catalog.go
Outdated
| for _, row := range rows { | ||
| databaseID := tree.MustBeDOid(row[0]) | ||
| roleName := tree.MustBeDString(row[1]) | ||
| roleID := tree.NewDOid(0) |
There was a problem hiding this comment.
Oops I dunno where the comment went, there's a oidZero constant
Release note (sql change): The pg_db_role_setting table of the pg_catalog is now implemented. When `ALTER ROLE ... SET var` is used to configure per-role defaults, these default settings will be populated in pg_db_role_setting. This table contains the same data no matter which database the current session is using. See https://www.postgresql.org/docs/13/catalog-pg-db-role-setting.html
rafiss
force-pushed
the
pg-db-role-setting
branch
from
0e8b700
to
28b5534
Compare
|
bors r=RichardJCai |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
touches #21151
Release note (sql change): The pg_db_role_setting table of the
pg_catalog is now implemented. When
ALTER ROLE ... SET varis used to configure per-role defaults, these default settings will be
populated in pg_db_role_setting. This table contains the same data no
matter which database the current session is using.
See https://www.postgresql.org/docs/13/catalog-pg-db-role-setting.html