New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.2: server: VIEWACTIVITY role gates unredacted nodes info #78275
release-21.2: server: VIEWACTIVITY role gates unredacted nodes info #78275
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Previously, the `Nodes` and `NodesUI` endpoints were gated behind the Admin role. For the former endpoint requests would fail if the user didn't have the Admin role, and for the latter, we'd show partially redacted information that omitted hostnames and IP addresses. This was deemed problematic for customers who did not want to set the Admin role just to grant a user the ability to view detailed node information about the cluster. This PR changes the role gate for the endpoints above to use the `VIEWACTIVITY` role option. Users with the option will be able to access the `Nodes` endpoint and see unredacted nodes information at the `NodesUI` endpoint used by the DB Console. As a result, the nodes overview page as well as the node reports page will now show unredacted information to users with `VIEWACTIVITY`. (Existing functionality for Admins us also retained as those users implicitly have the `VIEWACTIVITY` role.) Resolves cockroachdb#77665 Release note (ui change, security update, api change): The `_status/nodes` endpoint is avaible to all users with the `VIEWACTIVITY` role option, not just Admins. In the DB Console, the Nodes Overview and Node Reports pages will now display unredacted information containing node hostnames and IP addresses for all users with the `VIEWACTIVITY` role option. Previously this was also gated for Admins only.
3042edf
to
bda465b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @rafiss)
Backport 1/1 commits from #78045.
/cc @cockroachdb/release
Release justification: high-priority need from customer that keeps existing functionality and adds ability to use the additional SQL role
Previously, the
Nodes
andNodesUI
endpoints were gated behind theAdmin role. For the former endpoint requests would fail if the user
didn't have the Admin role, and for the latter, we'd show partially
redacted information that omitted hostnames and IP addresses.
This was deemed problematic for customers who did not want to set the
Admin role just to grant a user the ability to view detailed node
information about the cluster.
This PR changes the role gate for the endpoints above to use the
VIEWACTIVITY
role option. Users with the option will be able to accessthe
Nodes
endpoint and see unredacted nodes information at theNodesUI
endpoint used by the DB Console.As a result, the nodes overview page as well as the node reports page
will now show unredacted information to users with
VIEWACTIVITY
.(Existing functionality for Admins us also retained as those users
implicitly have the
VIEWACTIVITY
role.)Resolves #77665
Release note (ui change, security update, api change): The
_status/nodes
endpoint is avaible to all users with theVIEWACTIVITY
role option, not just Admins. In the DB Console, theNodes Overview and Node Reports pages will now display unredacted
information containing node hostnames and IP addresses for all users
with the
VIEWACTIVITY
role option. Previously this was also gated forAdmins only.