Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: sql: various COPY improvements #78417

Merged
merged 6 commits into from Mar 29, 2022
Merged

release-22.1: sql: various COPY improvements #78417

merged 6 commits into from Mar 29, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 24, 2022 •
edited by otan

Backport 5/5 commits from #78303 on behalf of @otan.

/cc @cockroachdb/release

Refs: #41608

See individual commits for details.

Release justification: low risk new feature for tactical support of third party tool

@otan
sql: amend COPY to use CRDB csv implementation
3a6fdf2 
Release note: None
@otan
parser: add unimplemented syntax for all the COPY options
c369a1e 
Release note: None
@otan
tree: add pgcodes to multiple specified COPY options
5a75832 
Release note: None
@otan
encoding/csv: add escape logic
84762f0 
Add `ESCAPE` logic to the `encoding/csv` package, for exposure to
SQL at a later stage.

It is worth noting I wrote this in the "safest" backportable way
possible. Ideally we'd rewrite the read logic to be more "parser"-like
to account for the change in QUOTE case, but that's a lot riskier to
backport.

Release note: None
@otan
sql: implement COPY FROM ... ESCAPE ...
8da094a 
Release note (sql change): Implemented the `COPY FROM ... ESCAPE ...`
syntax.
@blathers-crl blathers-crl bot requested a review from a team March 24, 2022 13:06
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 24, 2022 13:06
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-78303 branch from 62df0c5 to 8da094a Compare March 24, 2022 13:06
@blathers-crl blathers-crl bot requested review from ajstorm, otan and rafiss March 24, 2022 13:06
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 24, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 24, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

ajstorm
ajstorm reviewed Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @blathers-crl[bot], @otan, and @rafiss)

pkg/util/encoding/csv/reader.go, line 132 at r1 (raw file):

	Comma rune

	// Escape, if unset, is the character used to escape certain characters

Nit: missed this yesterday - should this be "if set"?

@otan otan merged commit a8e0636 into release-22.1 Mar 29, 2022
@otan otan deleted the blathers/backport-release-22.1-78303 branch March 29, 2022 11:05
@cockroach-teamcity cockroach-teamcity mentioned this pull request Mar 29, 2022
Closed
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajstorm ajstorm ajstorm left review comments

@otan otan Awaiting requested review from otan

@rafiss rafiss Awaiting requested review from rafiss

Assignees

@otan otan

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @ajstorm @otan