Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql/backfill: include virtual key columns in column backfiller #87272

Merged
merged 1 commit into from Sep 1, 2022

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Sep 1, 2022

Backport 1/1 commits from #87207.

/cc @cockroachdb/release


We need these columns to encode the row. This rather egregious bug meant that
any table with a primary key which included a virtual column could not have
any columns added or dropped using the legacy schema changer's column
backfiller.

Backports will fix #80780
Backports will fix #86889

Release justification: Serious bug fix
Release note (bug fix): A bug in the column backfiller, which is used to add
or remove columns from tables, failed to account for the need to read virtual
columns which were part of a primary key. Hash-sharded indexes, starting in
22.1, use virtual columns. Any hash-sharded table created in 22.1 or any
table created with a virtual column as part of its primary key would
indefinitely fail to complete a schema change which adds or removes
columns. This bug has been fixed.

We need these columns to encode the row. This rather egregious bug meant that
any table with a primary key which included a virtual column could not have
any columns added or dropped using the legacy schema changer's column
backfiller.

Backports will fix cockroachdb#80780
Backports will fix cockroachdb#86889

Release justification: Serious bug fix
Release note (bug fix): A bug in the column backfiller, which is used to add
or remove columns from tables, failed to account for the need to read virtual
columns which were part of a primary key. Hash-sharded indexes, starting in
22.1, use virtual columns. Any hash-sharded table created in 22.1 or any
table created with a virtual column as part of its primary key would
indefinitely fail to complete a schema change which adds or removes
columns. This bug has been fixed.
@blathers-crl
Copy link

blathers-crl bot commented Sep 1, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner merged commit 71c7686 into cockroachdb:release-22.1 Sep 1, 2022
@ajwerner ajwerner deleted the backport22.1-87207 branch September 1, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants