Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: ui: add apply recommendations to table details #92921

Merged
merged 1 commit into from Dec 5, 2022

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Dec 2, 2022

Backport 1/1 commits from #90070.

/cc @cockroachdb/release


On Table details page, we have a table with index
recommendations, which right now is focused on drop unused indexes. This commit adds the button the apply the recommendations, when there is one.

Fixes #86949
Screen Shot 2022-10-17 at 12 49 05 PM

Screen Shot 2022-10-17 at 12 49 11 PM

Release note (ui change): Add apply button on Table Details page (db console only), when there is a recommendation to drop an unused index.


Release justification: high benefit change

On Table details page, we have a table with index
recommendations, which right now is focused on drop
unused indexes. This commit adds the button the apply
the recommendations, when there is one.

Fixes cockroachdb#86949

Release note (ui change): Add apply button on Table Details
page (db console only), when there is a recommendation to
drop an unused index.
@maryliag maryliag requested a review from a team December 2, 2022 16:42
@blathers-crl
Copy link

blathers-crl bot commented Dec 2, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag maryliag merged commit 9530659 into cockroachdb:release-22.2 Dec 5, 2022
@maryliag maryliag deleted the backport22.2-90070 branch December 5, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants