Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: cli,server: enable cockroach on permissionless cwd #94927

Merged
merged 1 commit into from Jan 10, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 9, 2023

Backport 1/1 commits from #94894 on behalf of @knz.

/cc @cockroachdb/release


Fixes #28888.
Informs zd#15320.

Prior to this patch, running any cockroach subcommand on a permissionless cwd would fail in two ways:

  • because the computation for the default store path was attempting to access cwd to compute an absolute path.
  • because the GEOS initialization was trying to find the dynamically loadable module relative to cwd.

This patch changes the former to delay initialization of the configuration until an actual server command is executed; and the latter to tolerate a permissionless cwd.

Release note (bug fix): It is now possible to run cockroach version and cockroach start (and possibly other sub-commands) when the user running the command does not have permission to access the current working directory.


Release justification: bug fix to reduce operational friction

Prior to this patch, running any `cockroach` subcommand
on a permissionless cwd would fail in two ways:

- because the computation for the default store path
  was attempting to access cwd to compute an absolute
  path.
- because the GEOS initialization was trying to find
  the dynamically loadable module relative to cwd.

This patch changes the former to delay initialization of the
configuration until an actual server command is executed;
and the latter to tolerate a permissionless cwd.

Release note (bug fix): It is now possible to run `cockroach version`
and `cockroach start` (and possibly other sub-commands) when the user
running the command does not have permission to access the current
working directory.
@blathers-crl blathers-crl bot requested review from a team as code owners January 9, 2023 15:25
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-94894 branch from c1f34f2 to 1348901 Compare January 9, 2023 15:25
@blathers-crl blathers-crl bot requested a review from otan January 9, 2023 15:25
@blathers-crl
Copy link
Author

blathers-crl bot commented Jan 9, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 9, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz requested a review from aliher1911 January 10, 2023 08:09
@knz knz merged commit 05e4853 into release-22.2 Jan 10, 2023
@knz knz deleted the blathers/backport-release-22.2-94894 branch January 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants