Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: standardize column names in SHOW GRANTS #95532

Merged
merged 1 commit into from Jan 20, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jan 19, 2023

fixes #92768

cc @andf-crl when this is backported, the docs page may need another update.

Release note (sql change): The SHOW GRANTS ON EXTERNAL CONNECTION and SHOW SYSTEM GRANTS commands
now use a column name of privilege_type rather than privilege. For external connections, the name column was changed to connection_name. This makes the commands consistent with other SHOW GRANTS commands.

Release note (sql change): The SHOW GRANTS ON EXTERNAL CONNECTION and
SHOW SYSTEM GRANTS commands now use a column name of `privilege_type`
rather than `privilege`. For external connections, the `name` column was
changed to `connection_name`. This makes the commands consistent with other
SHOW GRANTS commands.
@rafiss rafiss added the backport-22.2.x Flags PRs that need to be backported to 22.2. label Jan 19, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andf-crl
Copy link

andf-crl commented Jan 19, 2023

Of course! Please create a DOCS ticket so I can action-on-merge! Or if your merge automatically creates a DOCS ticket, then that's all that's needed. Thanks much.

Copy link
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rafiss
Copy link
Collaborator Author

rafiss commented Jan 20, 2023

tftr!

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Jan 20, 2023

Build succeeded:

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 1, 2023

@andf-crl
Copy link

andf-crl commented Feb 1, 2023

@rafiss Perfect thanks! v23.1 docs cut takes place next week: I'll do both together then. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-22.2.x Flags PRs that need to be backported to 22.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHOW GRANTS output column names mismatch
4 participants