Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updocs: remove reference to RoachNode #9649
Conversation
spencerkimball
assigned
tamird
Sep 30, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tamird
Sep 30, 2016
Collaborator
Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.
docs/design.md, line 86 at r1 (raw file):
 Each physical node exports two RPC-based key value API: one for
s/API/APIs/
docs/design.md, line 88 at r1 (raw file):
Each physical node exports two RPC-based key value API: one for external clients and one for internal clients (exposing sensitive operational features). Both services accept batches of KV requests and
s/KV//g from this sentence.
docs/design.md, line 90 at r1 (raw file):
operational features). Both services accept batches of KV requests and return batches of KV responses. Nodes are symmetric in capabilties and exported interfaces. Each has the same binary and may assume any
s/. E/; e/
docs/design.md, line 91 at r1 (raw file):
return batches of KV responses. Nodes are symmetric in capabilties and exported interfaces. Each has the same binary and may assume any roles.
s/roles/role/
docs/design.md, line 616 at r1 (raw file):
Nodes maintain a separate instance of RocksDB for each disk. Each RocksDB instance hosts any number of ranges. RPCs arriving at a node
s/range/replicas/
docs/design.md, line 617 at r1 (raw file):
Nodes maintain a separate instance of RocksDB for each disk. Each RocksDB instance hosts any number of ranges. RPCs arriving at a node are multiplexed based on the disk name to the appropriate RocksDB
s/multiplexed/routed/ and remove "disk name" lies
docs/design.md, line 869 at r1 (raw file):
(or a range of keys) that the command accesses and (2) the ID of a range which the key(s) belongs to. When receiving a command, a node looks up a range by the specified Range ID and checks if the range is
so much inaccuracy here :(
docs/design.md, line 1352 at r1 (raw file):
distributed cluster. In addition to the gateway for external DB client traffic, each Node provides the full key/value API (including all internal methods) via
wrap while you're here
Comments from Reviewable
|
Reviewed 1 of 1 files at r1. docs/design.md, line 86 at r1 (raw file):
s/API/APIs/ docs/design.md, line 88 at r1 (raw file):
s/KV//g from this sentence. docs/design.md, line 90 at r1 (raw file):
s/. E/; e/ docs/design.md, line 91 at r1 (raw file):
s/roles/role/ docs/design.md, line 616 at r1 (raw file):
s/range/replicas/ docs/design.md, line 617 at r1 (raw file):
s/multiplexed/routed/ and remove "disk name" lies docs/design.md, line 869 at r1 (raw file):
so much inaccuracy here :( docs/design.md, line 1352 at r1 (raw file):
wrap while you're here Comments from Reviewable |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
spencerkimball
Sep 30, 2016
Member
Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.
docs/design.md, line 86 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
s/API/APIs/
docs/design.md, line 88 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
s/KV//g from this sentence.
docs/design.md, line 90 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
s/. E/; e/
docs/design.md, line 91 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
s/roles/role/
docs/design.md, line 616 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
s/range/replicas/
docs/design.md, line 617 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
s/multiplexed/routed/ and remove "disk name" lies
docs/design.md, line 869 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
so much inaccuracy here :(
docs/design.md, line 1352 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
wrap while you're here
Comments from Reviewable
|
Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed. docs/design.md, line 86 at r1 (raw file):
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
a-robinson
Sep 30, 2016
Member
Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.
Comments from Reviewable
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tamird
Sep 30, 2016
Collaborator
Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.
Comments from Reviewable
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nvanbenschoten
Sep 30, 2016
Member
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.
docs/design.md, line 869 at r1 (raw file):
Previously, spencerkimball (Spencer Kimball) wrote…
This is another section which needs updating. I was thinking we give it to @nvanbenschoten
Comments from Reviewable
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. docs/design.md, line 869 at r1 (raw file):
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Squash plz |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
What do I do to squash? |
spencerkimball commentedSep 30, 2016
•
edited by arjunravinarayan
This change is