New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove reference to RoachNode #9649

Merged
merged 2 commits into from Oct 2, 2016

Conversation

Projects
None yet
4 participants
@spencerkimball
Member

spencerkimball commented Sep 30, 2016

This change is Reviewable

@tamird

This comment has been minimized.

Show comment
Hide comment
@tamird

tamird Sep 30, 2016

Collaborator

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.


docs/design.md, line 86 at r1 (raw file):

![Ranges](media/ranges.png)

Each physical node exports two RPC-based key value API: one for

s/API/APIs/


docs/design.md, line 88 at r1 (raw file):

Each physical node exports two RPC-based key value API: one for
external clients and one for internal clients (exposing sensitive
operational features). Both services accept batches of KV requests and

s/KV//g from this sentence.


docs/design.md, line 90 at r1 (raw file):

operational features). Both services accept batches of KV requests and
return batches of KV responses. Nodes are symmetric in capabilties and
exported interfaces. Each has the same binary and may assume any

s/. E/; e/


docs/design.md, line 91 at r1 (raw file):

return batches of KV responses. Nodes are symmetric in capabilties and
exported interfaces. Each has the same binary and may assume any
roles.

s/roles/role/


docs/design.md, line 616 at r1 (raw file):

Nodes maintain a separate instance of RocksDB for each disk. Each
RocksDB instance hosts any number of ranges. RPCs arriving at a node

s/range/replicas/


docs/design.md, line 617 at r1 (raw file):

Nodes maintain a separate instance of RocksDB for each disk. Each
RocksDB instance hosts any number of ranges. RPCs arriving at a node
are multiplexed based on the disk name to the appropriate RocksDB

s/multiplexed/routed/ and remove "disk name" lies


docs/design.md, line 869 at r1 (raw file):

(or a range of keys) that the command accesses and (2) the ID of a
range which the key(s) belongs to. When receiving a command, a node
looks up a range by the specified Range ID and checks if the range is

so much inaccuracy here :(


docs/design.md, line 1352 at r1 (raw file):

distributed cluster.

In addition to the gateway for external DB client traffic, each Node provides the full key/value API (including all internal methods) via

wrap while you're here


Comments from Reviewable

Collaborator

tamird commented Sep 30, 2016

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.


docs/design.md, line 86 at r1 (raw file):

![Ranges](media/ranges.png)

Each physical node exports two RPC-based key value API: one for

s/API/APIs/


docs/design.md, line 88 at r1 (raw file):

Each physical node exports two RPC-based key value API: one for
external clients and one for internal clients (exposing sensitive
operational features). Both services accept batches of KV requests and

s/KV//g from this sentence.


docs/design.md, line 90 at r1 (raw file):

operational features). Both services accept batches of KV requests and
return batches of KV responses. Nodes are symmetric in capabilties and
exported interfaces. Each has the same binary and may assume any

s/. E/; e/


docs/design.md, line 91 at r1 (raw file):

return batches of KV responses. Nodes are symmetric in capabilties and
exported interfaces. Each has the same binary and may assume any
roles.

s/roles/role/


docs/design.md, line 616 at r1 (raw file):

Nodes maintain a separate instance of RocksDB for each disk. Each
RocksDB instance hosts any number of ranges. RPCs arriving at a node

s/range/replicas/


docs/design.md, line 617 at r1 (raw file):

Nodes maintain a separate instance of RocksDB for each disk. Each
RocksDB instance hosts any number of ranges. RPCs arriving at a node
are multiplexed based on the disk name to the appropriate RocksDB

s/multiplexed/routed/ and remove "disk name" lies


docs/design.md, line 869 at r1 (raw file):

(or a range of keys) that the command accesses and (2) the ID of a
range which the key(s) belongs to. When receiving a command, a node
looks up a range by the specified Range ID and checks if the range is

so much inaccuracy here :(


docs/design.md, line 1352 at r1 (raw file):

distributed cluster.

In addition to the gateway for external DB client traffic, each Node provides the full key/value API (including all internal methods) via

wrap while you're here


Comments from Reviewable

@spencerkimball

This comment has been minimized.

Show comment
Hide comment
@spencerkimball

spencerkimball Sep 30, 2016

Member

Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.


docs/design.md, line 86 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/API/APIs/

Done.

docs/design.md, line 88 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/KV//g from this sentence.

Done.

docs/design.md, line 90 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/. E/; e/

Done.

docs/design.md, line 91 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/roles/role/

Done.

docs/design.md, line 616 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/range/replicas/

Done.

docs/design.md, line 617 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/multiplexed/routed/ and remove "disk name" lies

Done.

docs/design.md, line 869 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

so much inaccuracy here :(

This is another section which needs updating. I was thinking we give it to @nvanbenschoten

docs/design.md, line 1352 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

wrap while you're here

This section is gone now.

Comments from Reviewable

Member

spencerkimball commented Sep 30, 2016

Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.


docs/design.md, line 86 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/API/APIs/

Done.

docs/design.md, line 88 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/KV//g from this sentence.

Done.

docs/design.md, line 90 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/. E/; e/

Done.

docs/design.md, line 91 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/roles/role/

Done.

docs/design.md, line 616 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/range/replicas/

Done.

docs/design.md, line 617 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/multiplexed/routed/ and remove "disk name" lies

Done.

docs/design.md, line 869 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

so much inaccuracy here :(

This is another section which needs updating. I was thinking we give it to @nvanbenschoten

docs/design.md, line 1352 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

wrap while you're here

This section is gone now.

Comments from Reviewable

@a-robinson

This comment has been minimized.

Show comment
Hide comment
@a-robinson

a-robinson Sep 30, 2016

Member

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


Comments from Reviewable

Member

a-robinson commented Sep 30, 2016

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


Comments from Reviewable

@tamird

This comment has been minimized.

Show comment
Hide comment
@tamird

tamird Sep 30, 2016

Collaborator

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

Collaborator

tamird commented Sep 30, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@nvanbenschoten

This comment has been minimized.

Show comment
Hide comment
@nvanbenschoten

nvanbenschoten Sep 30, 2016

Member

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


docs/design.md, line 869 at r1 (raw file):

Previously, spencerkimball (Spencer Kimball) wrote…

This is another section which needs updating. I was thinking we give it to @nvanbenschoten

Sure, I'll take this section.

Comments from Reviewable

Member

nvanbenschoten commented Sep 30, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


docs/design.md, line 869 at r1 (raw file):

Previously, spencerkimball (Spencer Kimball) wrote…

This is another section which needs updating. I was thinking we give it to @nvanbenschoten

Sure, I'll take this section.

Comments from Reviewable

@tamird

This comment has been minimized.

Show comment
Hide comment
@tamird

tamird Sep 30, 2016

Collaborator

Squash plz

Collaborator

tamird commented Sep 30, 2016

Squash plz

@spencerkimball

This comment has been minimized.

Show comment
Hide comment
@spencerkimball

spencerkimball Oct 1, 2016

Member

What do I do to squash?

Member

spencerkimball commented Oct 1, 2016

What do I do to squash?

@spencerkimball spencerkimball merged commit be1c3d0 into master Oct 2, 2016

3 checks passed

ci/teamcity TeamCity build finished
Details
code-review/reviewable Review complete: 0 of 0 LGTMs obtained (and 2 stale)
Details
licence/cla Contributor License Agreement is signed.
Details

@spencerkimball spencerkimball deleted the spencerkimball/roachnode-ref-cleanup branch Oct 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment