31,581 issues in cockroachdb/cockroach
tidy up some correctness issues reported by go vet
I use go vet (http://golang.org/cmd/go/#hdr-Run_go_tool_vet_on_packages) as a presubmit hook on almost all of my go code. It definitely helps with finding correctness problems.
-
Opened by andybons
Feb 14, 2014 - 3 comments
add pre-commit hook & convenience script to add it. fix some vet errors.
The precommit will run - go vet - all package tests - gofmt Within the cockroach dir, just run the initrepo.sh script and it will be enabled for you.
-
Opened by andybons
Feb 14, 2014 - 12 comments
fix golint reports
With the exception of the renaming of MIN_GROUP and MAX_GROUP this is almost completely comment changes that will put us within the stylistic goodwill of golint. There were some other things I wanted ...
-
Opened by andybons
Feb 15, 2014
Added diff of an InfoStore with a supplied Filter
Diffs determine approximate difference in number of keys known by the builder of the Filter but unknown to the InfoStore. It's an heuristic for how good of a gossip peer the builder of the Filter would ...
-
Opened by spencerkimball
Feb 15, 2014 - 8 comments
Add field names to composite literals
While more verbose, composite literals with explicit field names are a good idea because: - Bugs (sometimes very subtle) can arise simply by changing the order of fields in a struct type declaration. ...
-
Opened by andybons
Feb 15, 2014 - 3 comments
Rename initrepo.sh. Update README.md with hacking instructions.
-
Opened by andybons
Feb 15, 2014 - 1 comment
add myself to AUTHORS
Wasn’t sure what the difference was between original authors and partial contributors. Since I wasn’t a part of the initial design doc discussion, putting myself in the partial list.
-
Opened by andybons
Feb 16, 2014 - 1 comment
reduce visibility of hasher and filter
also updates field comments to be idiomatic, albeit more verbose.
-
Opened by andybons
Feb 16, 2014 - 3 comments
Visibility fixes for group, info, infostore.
-
Opened by spencerkimball
Feb 16, 2014