31,581 issues in cockroachdb/cockroach
tidy up some correctness issues reported by go vet
I use go vet (http://golang.org/cmd/go/#hdr-Run_go_tool_vet_on_packages) as a presubmit hook on almost all of my go code. It definitely helps with finding correctness problems.
-
Opened by andybons
Feb 14, 2014 - 3 comments
add pre-commit hook & convenience script to add it. fix some vet errors.
The precommit will run - go vet - all package tests - gofmt Within the cockroach dir, just run the initrepo.sh script and it will be enabled for you.
-
Opened by andybons
Feb 14, 2014 - 12 comments
Database RocksDB
Instead of RocksDB, you could use a database built in Go (to a better deploy): - Bolt is a pure Go key/value store inspired by the LMDB project. Bolt currently works on Mac OS and Linux. Windows ...
-
Opened by tredoe
Apr 23, 2014 - 3 comments
Disallow the insertion of empty keys
From @tobstar87: I'm wondering if we allow empty keys to be inserted. The rockdb handler doesn't handle it very well, it will crash whenever encountering Key("") for anything that's ...
-
Opened by andybons
Jun 3, 2014 - 4 comments
Minor fixes in the way of init & start
Played around with it trying to boot it up, and fixed what I think were some fairly self-explanatory bugs on the way. With these changes, I can init a cluster (apparently successfully so), upon booting ...
-
Opened by tschottdorf
Jun 2, 2014 - 7 comments
Listen on random ports for tests instead of :8080
Currently the servers that are used when testing the healthz endpoints are using the default port from the flag (8080). These should be randomized via port :0 Relevant error log from failing test: E0525 ...
-
Opened by andybons
Jun 3, 2014 - 1 comment
Add field names to composite literals
While more verbose, composite literals with explicit field names are a good idea because: - Bugs (sometimes very subtle) can arise simply by changing the order of fields in a struct type declaration. ...
-
Opened by andybons
Feb 15, 2014 - 3 comments
Use parameter, not constant
Spotted this while skimming through Cockroach's code.
-
Opened by maniksurtani
May 20, 2014 - 1 comment
fix golint reports
With the exception of the renaming of MIN_GROUP and MAX_GROUP this is almost completely comment changes that will put us within the stylistic goodwill of golint. There were some other things I wanted ...
-
Opened by andybons
Feb 15, 2014