…bles An intent which straddles an sstable can lead an incremental iterator to incorrectly ignore an sstable. In order to fix this, when an intent straddles an sstable (i.e. the metadata key is the last key in the sstable) we need to include the intent's timestamp in the timestamp bounds. We don't need to do this for interior intents because we'll already be including the intent's timestamp as it is contained in the next key following the intent. Add `TestMVCCIncrementalIteratorIntentStraddlesSStables` which demonstrates the problem. Fixes #28358 Release note (bug fix): Fix a rare scenario where a backup could incorrectly include a key for a transaction which was aborted.

Sources for libroach.

Formatting

Code is formatted using clang-format.

To install:

download LLVM 5.0 for your OS/arch
extract archive
place the archive's bin/clang-format in your path

If you use a package manager, make sure it uses clang-format from LLVM 5.0 (clang-format --version).

To use, do one of:

run make c-deps-fmt from the cockroachdb/cockroach repo
add clang-format -i <filename> as a save hook in your editor.

Testing

Run make check-libroach from the repository root. We use gtest.

..
Failed to load latest commit information.
ccl	libroach: ensure encryption flags are passed if previously used.	Aug 16, 2018
include	engine: avoid committing empty batches	Sep 19, 2018
protos	sql: fix (really: add) the handling of bit arrays	Sep 4, 2018
protosccl/ccl	libroach: Log encryption actions	Jul 24, 2018
rocksdbutils	libroach: create file_registry entries for plaintext files.	Jul 11, 2018
.clang-format	libroach: reduce clang-format line length to 100.	Jan 4, 2018
CMakeLists.txt	rocksdb: Link in sst_dump as a debug command	Aug 9, 2018
README.md	libroach: update README	Jan 20, 2018
batch.cc	libroach: Be more paranoid in DBBatchInserter	Oct 4, 2018
batch.h	debug: add encryption-status command.	Aug 14, 2018
cache.cc	libroach: further decomposition of db.cc	Jan 22, 2018
cache.h	libroach: remove emacs c++-mode comments	Jan 23, 2018
chunked_buffer.cc	libroach: detected leaked iterators	Mar 1, 2018
chunked_buffer.h	libroach: detected leaked iterators	Mar 1, 2018
comparator.cc	libroach: further decomposition of db.cc	Jan 22, 2018
comparator.h	libroach: remove emacs c++-mode comments	Jan 23, 2018
db.cc	engine: avoid committing empty batches	Sep 19, 2018
db.h	libroach: fix tests on macOS	Jul 24, 2018
db_test.cc	libroach: ensure encryption flags are passed if previously used.	Aug 16, 2018
defines.h	libroach: initial split of db.cc	Jan 22, 2018
encoding.cc	engine: require iterators to specify an upper bound	Jul 5, 2018
encoding.h	engine: require iterators to specify an upper bound	Jul 5, 2018
encoding_test.cc	libroach: add EncodeUvarint64 and DecodeUvarint64 functions	Apr 6, 2018
engine.cc	engine: avoid committing empty batches	Sep 19, 2018
engine.h	engine: avoid committing empty batches	Sep 19, 2018
env_manager.h	debug: add encryption-status command.	Aug 14, 2018
eventlistener.cc	libroach: reduce clang-format line length to 100.	Jan 4, 2018
eventlistener.h	libroach: reduce clang-format line length to 100.	Jan 4, 2018
file_registry.cc	libroach: create file_registry entries for plaintext files.	Jul 11, 2018
file_registry.h	libroach: ensure encryption flags are passed if previously used.	Aug 16, 2018
file_registry_test.cc	libroach: add basic file encryption stats.	Jun 29, 2018
fmt.h	libroach: improve format string hygiene	Feb 28, 2018
getter.cc	libroach: further decomposition of db.cc	Jan 22, 2018
getter.h	libroach: remove emacs c++-mode comments	Jan 23, 2018
godefs.cc	libroach: Log encryption actions	Jul 24, 2018
godefs.h	libroach: Log encryption actions	Jul 24, 2018
iterator.cc	engine: require iterators to specify an upper bound	Jul 5, 2018
iterator.h	engine: require iterators to specify an upper bound	Jul 5, 2018
keys.h	engine: require iterators to specify an upper bound	Jul 5, 2018
ldb.cc	libroach: further decomposition of db.cc	Jan 22, 2018
merge.cc	engine: Fix TS Merge consistency error	Jun 15, 2018
merge.h	ts: Implement new on-disk format for time series	Jun 5, 2018
merge_test.cc	libroach: format C++ code.	Jun 6, 2018
mvcc.cc	storage: prohibit splitting on range.StartKey for non-SQL ranges	Sep 21, 2018
mvcc.h	storage: refresh spans on InitPut; heed tombstones on Refresh / Refre…	Feb 23, 2018
options.cc	libroach: make DBSstFileWriter output work with time bound iterator	Jul 27, 2018
options.h	libroach: Log encryption actions	Jul 24, 2018
plaintext_stream.h	libroach: fix concurrent access to same file when using encryption	Jun 4, 2018
snapshot.cc	debug: add encryption-status command.	Aug 14, 2018
snapshot.h	debug: add encryption-status command.	Aug 14, 2018
sst_dump.cc	rocksdb: Link in sst_dump as a debug command	Aug 9, 2018
status.h	c-deps: `make c-deps-fmt`	Apr 6, 2018
testutils.cc	Merge #27880	Jul 24, 2018
testutils.h	libroach: rotate encryption keys while running.	Aug 1, 2018
timebound.cc	ccl/storageccl/engineccl: properly handle intents which straddle ssta…	Oct 12, 2018
timebound.h	libroach: make DBSstFileWriter output work with time bound iterator	Jul 27, 2018
timestamp.h	libroach: remove emacs c++-mode comments	Jan 23, 2018
utils.cc	libroach: add basic file encryption stats.	Jun 29, 2018
utils.h	libroach: add basic file encryption stats.	Jun 29, 2018

cockroachdb/cockroach

README.md

Sources for libroach.

Formatting

Testing