From 3558b4c43011257edca7eb47efb8ade0a8dfd879 Mon Sep 17 00:00:00 2001 From: Nick Vigilante Date: Thu, 18 May 2023 11:13:16 -0400 Subject: [PATCH] do not merge --- .github/scripts/docs-prs-reviews.go | 3 ++- .github/workflows/foo.yml | 19 +++++++++++++++++++ .github/workflows/pr-reviews.yml | 12 +++++++----- v23.1/alembic.md | 2 ++ 4 files changed, 30 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/foo.yml diff --git a/.github/scripts/docs-prs-reviews.go b/.github/scripts/docs-prs-reviews.go index 16705229a2a..abcaa594626 100644 --- a/.github/scripts/docs-prs-reviews.go +++ b/.github/scripts/docs-prs-reviews.go @@ -97,12 +97,13 @@ func main() { if err != nil { log.Fatalf("error: %v\n", err) } + fmt.Printf("%v\n", docsPrsMembers) _, authorIsDocsPrsMember := docsPrsMembers[params.PrAuthor] if authorIsDocsPrsMember { fmt.Printf(`User "%s" is a member of docs-prs, so no docs-prs approval required.`, params.PrAuthor) os.Exit(0) } - fmt.Printf(`User "%s" is not a member of docs-prs. Checking for docs-prs team approval...\n`, params.PrAuthor) + fmt.Printf(`User "%s" is not a member of docs-prs. Checking for docs-prs team approval...`, params.PrAuthor) prReviews, err := searchDocsPrReviewers(params.Token, params.PrNumber) if err != nil { diff --git a/.github/workflows/foo.yml b/.github/workflows/foo.yml new file mode 100644 index 00000000000..01b129898f6 --- /dev/null +++ b/.github/workflows/foo.yml @@ -0,0 +1,19 @@ +name: Foo +on: + pull_request: + +jobs: + foo: + if: github.event.pull_request.draft == false + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@main + + + - name: Run PR review check + env: + FOO: ${{ secrets.FOO }} + run: | + size=${#FOO} + echo "$size" diff --git a/.github/workflows/pr-reviews.yml b/.github/workflows/pr-reviews.yml index 096bfd106cb..0c54c1f040c 100644 --- a/.github/workflows/pr-reviews.yml +++ b/.github/workflows/pr-reviews.yml @@ -1,15 +1,17 @@ name: PR Review on: pull_request: - types: - - opened - - reopened - - ready_for_review + # types: + # - opened + # - reopened + # - ready_for_review pull_request_review: types: - submitted - edited - dismissed + +permissions: read-all jobs: pr-review: @@ -26,7 +28,7 @@ jobs: - name: Run PR review check env: - GITHUB_TOKEN: ${{ secrets.TOKEN_FOR_ORG_MEMBERSHIP }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_AUTHOR: ${{ github.event.pull_request.user.login }} PR_NUMBER: ${{ github.event.pull_request.number }} run: go run .github/scripts/docs-prs-reviews.go diff --git a/v23.1/alembic.md b/v23.1/alembic.md index 8ddc39321cf..eec40923462 100644 --- a/v23.1/alembic.md +++ b/v23.1/alembic.md @@ -11,6 +11,8 @@ For a detailed tutorial about using Alembic, see [the Alembic documentation site For information about specific migration tasks, see Alembic's [Cookbook](https://alembic.sqlalchemy.org/en/latest/cookbook.html). +do not merge + ## Before you begin Before you begin the tutorial, [install CockroachDB](install-cockroachdb.html).