DOC-14144 Product Change- PR #148525 - pkg/util/log: add otlp log sink #20320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twork collectors and Set OTLP. In logging-use-cases.md, modified example for Network logging with log buffering to use OTLP instead of Fluentd.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Contributor
Author
|
Hi @arjunmahishi, I assigned you to do this docs review since you reviewed Mudit Somani’s code prs. tia |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
arjunmahishi
approved these changes
Sep 11, 2025
arjunmahishi
left a comment
arjunmahishi
left a comment
There was a problem hiding this comment.
Thank you @florence-crl!
I've left one suggestion. Rest looks good to me.
rmloveland
approved these changes
Sep 15, 2025
Contributor
rmloveland
left a comment
rmloveland
left a comment
There was a problem hiding this comment.
LGTM, all comments non-blocking take or leave
src/current/v25.4/configure-logs.md
Outdated
| | `mode` | Protocol used to export logs. Valid values `grpc` or `http`.<br><br>**Default:**`grpc` | | ||
| | `headers` | Map of key-value string pairs which will be appended to every request as custom gRPC or HTTP headers depending on the `mode` selected. For example, `"x-api-key": "YOUR_API_KEY_HERE"`. | | ||
| | `compression` | Compression for requests. Valid values `gzip` or `none`.<br><br>**Default:**`gzip` | | ||
| | `buffering` | Configures buffering of log messages for the sink, with the following sub-parameters:<ul><li>`max-staleness`: The maximum time a log message will wait in the buffer before a flush is triggered. Set to `0` to disable flushing based on elapsed time. Default: `5s`</li><li>`flush-trigger-size`: The number of bytes that will trigger the buffer to flush. Set to `0` to disable flushing based on accumulated size. Default: `1MiB`</li><li>`max-buffer-size`: The maximum size of the buffer: new log messages received when the buffer is full cause older messages to be dropped. Default: `50MiB`</li></ul>When `max-staleness` and `flush-trigger-size` are used together, whichever is reached first will trigger the flush. `buffering` is enabled by default for OTLP log sinks. To explicitly disable log buffering, specify `buffering: NONE` instead. This setting is typically disabled for [security-related logs]({% link {{ page.version.version }}/logging-use-cases.md %}#security-and-audit-monitoring). See [Log buffering](#log-buffering-for-network-sinks) for more details and usage.| |
Contributor
There was a problem hiding this comment.
suggest either bolding these uses of "Default: foo" or unbolding the prior ones in the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-14144 DOC-14437 DOC-14537 DOC-8496 DOC-14810
Rendered preview