-
Notifications
You must be signed in to change notification settings - Fork 477
Small PCR changes backport #20363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Small PCR changes backport #20363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a number of small changes from PCR overhaul doc and fixed broken links and typos More various changes More various changes - will elaborate as needed in comments Moved info Moved info to a more relevant section Fixed broken link Accidentally broke a link - fixed typo Fixed more broken links Lots of broken links from these updates- hopefully fixed the last ones Minor fixes from review A few minor changes based on Alicia's review
Fully backported DOC-14757 changes as far as v24.1.
* Various changes Added a number of small changes from PCR overhaul doc and fixed broken links and typos More various changes More various changes - will elaborate as needed in comments Moved info Moved info to a more relevant section Fixed broken link Accidentally broke a link - fixed typo Fixed more broken links Lots of broken links from these updates- hopefully fixed the last ones Minor fixes from review A few minor changes based on Alicia's review * Adjustments from review Some changes based on a review from Michael Butler * changed 'must' to 'may want to' one more change from review * Small change from review Small reword from review * Fixed broken links Fixed broken links * Apply suggestions from code review Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com> * Changes from docs review Changes from docs review --------- Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com>
Backported changes from review
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
florence-crl
approved these changes
Sep 18, 2025
Contributor
florence-crl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending suggestions
src/current/_includes/v24.1/physical-replication/show-virtual-cluster-responses.md
Outdated
Show resolved
Hide resolved
src/current/v24.1/physical-cluster-replication-technical-overview.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com>
Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: DOC-14757
Backporting changes from PR 20304 into versions 25.2, 24.3, and 24.1