Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PERSISTENT => true to php examples. #4804

Merged
merged 3 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@tim-o
Copy link
Contributor

commented May 14, 2019

@tim-o tim-o requested a review from rmloveland May 14, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 14, 2019

This change is Reviewable

@jseldess
Copy link
Contributor

left a comment

Thanks, @tim-o. I think you still need to apply this change to the secure versions for v2.0, v2.1, and v19.1? Those are just in <version>/app/.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rmloveland)

@tim-o

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@jseldess d'oh. Added!

@jseldess
Copy link
Contributor

left a comment

:lgtm:

Thanks, Tim!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rmloveland)

@tim-o tim-o merged commit 90af51f into master May 15, 2019

2 checks passed

GitHub CI (Docs) TeamCity build finished
Details
code-review/reviewable 1 of 0 LGTMs obtained (rmloveland)
Details

@jseldess jseldess removed the in progress label May 15, 2019

@tim-o tim-o deleted the php-code-update branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.