From 8d8efb9ab750323487dc66cb1cdd8946954baaea Mon Sep 17 00:00:00 2001 From: David Hartunian Date: Wed, 22 Apr 2026 16:55:19 -0400 Subject: [PATCH] build: bump min Go version to 1.25, add 1.26 to CI matrix Also fix a non-constant format string in fmttests that the Go 1.26 vet checker now flags. Co-Authored-By: roachdev-claude --- .github/workflows/ci.yaml | 8 ++++---- fmttests/datadriven_test.go | 2 +- go.mod | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ca7b472..4cdb7d1 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,8 +12,8 @@ jobs: strategy: matrix: go: - - "1.23" - - "1.24" + - "1.25" + - "1.26" steps: - uses: actions/checkout@v3 @@ -29,8 +29,8 @@ jobs: strategy: matrix: go: - - "1.23" - - "1.24" + - "1.25" + - "1.26" steps: - uses: actions/checkout@v3 diff --git a/fmttests/datadriven_test.go b/fmttests/datadriven_test.go index 77b9568..728c682 100644 --- a/fmttests/datadriven_test.go +++ b/fmttests/datadriven_test.go @@ -105,7 +105,7 @@ var leafCommands = map[string]commandFn{ }, "unimplemented": func(_ error, args []arg) error { - return issuelink.UnimplementedErrorf(issuelink.IssueLink{IssueURL: "https://mysite", Detail: "issuedetails"}, strfy(args)) + return issuelink.UnimplementedErrorf(issuelink.IssueLink{IssueURL: "https://mysite", Detail: "issuedetails"}, "%s", strfy(args)) }, } diff --git a/go.mod b/go.mod index 7297c44..d4215fc 100644 --- a/go.mod +++ b/go.mod @@ -1,8 +1,6 @@ module github.com/cockroachdb/errors -go 1.23.0 - -toolchain go1.23.8 +go 1.25.0 require ( github.com/cockroachdb/datadriven v1.0.2