Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide facility for retaining obsolete WALs, MANIFESTs, and sstables #284

Closed
petermattis opened this issue Sep 18, 2019 · 0 comments · Fixed by #321
Projects

Comments

@petermattis
Copy link
Collaborator

@petermattis petermattis commented Sep 18, 2019

Currently, obsolete WALs, MANIFESTs, and sstables are deleted as soon as possible. For debugging purposes it is sometimes useful to maintain the obsolete versions so the series of operations that led to a problem can be reconstructed. RocksDB provides DB.DisableFileDeletions. We could do similar, or perhaps have a vfs.FS wrapper that intercepts vfs.FS.Remove calls and instead renames to an "archive" directory.

hueypark added a commit to hueypark/pebble that referenced this issue Oct 1, 2019
…bles

For debugging purposes, db cleaner option can set as archive cleaner. If this option is set, the files are renamed to the archive directory instead of deleting.

Fixes cockroachdb#284
@petermattis petermattis added this to Incoming in Storage via automation Oct 1, 2019
@petermattis petermattis moved this from Incoming to In Progress in Storage Oct 1, 2019
hueypark added a commit to hueypark/pebble that referenced this issue Oct 2, 2019
…bles

For debugging purposes, db cleaner option can set as archive cleaner. If this option is set, the files are renamed to the archive directory instead of deleting.

Fixes cockroachdb#284
hueypark added a commit to hueypark/pebble that referenced this issue Oct 2, 2019
…bles

For debugging purposes, db cleaner option can set as archive cleaner. If this option is set, the files are renamed to the archive directory instead of deleting.

Fixes cockroachdb#284
hueypark added a commit to hueypark/pebble that referenced this issue Oct 4, 2019
…bles

For debugging purposes, db cleaner option can set as archive cleaner. If this option is set, the files are renamed to the archive directory instead of deleting.

Fixes cockroachdb#284
@petermattis petermattis moved this from In Progress to Done in Storage Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Storage
  
Done (last milestone)
1 participant
You can’t perform that action at this time.