util/channel.h: remove an invalid const specifier #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knz
changed the title
This error was found by Clang 10.
|
@petermattis there's a non-Java test failure at https://travis-ci.org/github/cockroachdb/rocksdb/jobs/669596695?utm_medium=notification&utm_source=github_status something to do with column families. Is this ok? |
|
Hmm, I can't see why this change would have caused that. I also can't find the button in Travis to restart the build. Did they remove it? |
Logging out of Travis and back in fixed that problem. I've restarted the build. |
|
ok so all the remaining failures are java-related. merging. |
peilun-conflux
pushed a commit
to Conflux-Chain/rocksdb
that referenced
this pull request
Aug 4, 2020
of 'std::lock_guard<std::mutex>'. Apply the fix in cockroachdb#79.
Thegaram
pushed a commit
to Thegaram/rocksdb
that referenced
this pull request
Apr 2, 2021
of 'std::lock_guard<std::mutex>'. Apply the fix in cockroachdb#79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error was found by Clang 10.
Informs cockroachdb/cockroach#46300
This change is