New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for emphasized comments #7

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@nkantar

nkantar commented Feb 4, 2017

I personally prefer comments to be more prominent than code, for a variety of reasons:

  • Well written comments are the reader's guide through the code;
  • Outdated comments are much more bothersome and thus less likely to be ignored;
  • Commented out code is far more annoying and is more likely to be deleted.

However, not everyone feels the same way, so I didn't make a wholesale change to the colorscheme, instead implementing a feature flag to make them more visible.

The flag is off by default, resulting in the colorscheme looking as it does now:

iceberg-regular-comments

Enabling it via

let g:iceberg_emphasize_comments=1

turns the comments white:

iceberg-emphasize-comments

Hopefully this seems like it could be helpful. I'm happy to maintain my own fork, but would obviously prefer the theme to support it out of the box, and I'd like to give back. Thanks for such a great colorscheme! 馃嚘馃嚩

Add support for emphasized comments
Comments can be colored white by setting g:iceberg_emphasize_comments=1
@cocopon

This comment has been minimized.

Show comment
Hide comment
@cocopon

cocopon Feb 6, 2017

Owner

Thank you for the kind pull request. Very interesting! I think writing good comments is important too.

Maybe adding options helps professional users, but...

  • it increases complexity
  • it increases a maintenance cost

Currently I want to focus a core value of the color scheme, so I think it's good to maintain the feature as your fork. Sorry 馃檱

Owner

cocopon commented Feb 6, 2017

Thank you for the kind pull request. Very interesting! I think writing good comments is important too.

Maybe adding options helps professional users, but...

  • it increases complexity
  • it increases a maintenance cost

Currently I want to focus a core value of the color scheme, so I think it's good to maintain the feature as your fork. Sorry 馃檱

@cocopon cocopon closed this Feb 6, 2017

@nkantar

This comment has been minimized.

Show comment
Hide comment
@nkantar

nkantar Feb 6, 2017

No problem, happy to do so.

Thanks again for the theme itself!

nkantar commented Feb 6, 2017

No problem, happy to do so.

Thanks again for the theme itself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment