Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change regexp to test remote asset #155

Merged

Conversation

holycanvas
Copy link
Contributor

@holycanvas holycanvas commented Aug 3, 2020

only pass http and https.

@holycanvas holycanvas requested a review from PPpro Aug 3, 2020
@@ -32,7 +32,7 @@ var callbacks = [];
var cleaning = false;
var errTest = /the maximum size of the file storage/;
var suffix = 0;
const REGEX = /^\w+:\/\/.*/;
const REGEX = /^http[s]{0,1}:\/\/.*/;
Copy link
Collaborator

@PPpro PPpro Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以用 ^https?

Copy link
Contributor Author

@holycanvas holycanvas Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cocos-robot cocos-robot changed the base branch from v2.4.2-release to v2.4.3-release Aug 3, 2020
Copy link
Contributor

@cocos-robot cocos-robot left a comment

We switched this PR to v2.4.3-release because v2.4.2-release is about to be deleted.

PPpro
PPpro approved these changes Aug 3, 2020
@PPpro PPpro merged commit c40210d into cocos-creator-packages:v2.4.3-release Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants