fix cc.sys.os && audio downloading on Alipay iOS #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holycanvas
reviewed
Nov 15, 2019
| function downloadAudio (item, callback) { | ||
| if (cc.sys.__audioSupport.format.length === 0) { | ||
| return new Error(debug.getError(4927)); |
| // FIX audio downlaod error on Alipay iOS 10.1.78 | ||
| if (cc.sys.os === cc.sys.OS_IOS) { | ||
| cc.loader.downloader.addHandlers({ |
There was a problem hiding this comment.
这里执行是在common里面loader之后？
holycanvas
reviewed
Nov 15, 2019
| callback(new Error('load audio failed ' + item.url), null); | ||
| }); | ||
| audio.src = item.url; |
There was a problem hiding this comment.
没问题，最终只是取 audio.src
downloader 阶段只是在底层生成一份缓存
holycanvas
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
changeLog:
cc.sys.os没定义的问题 （原因是 getSystemInfoSync() 接口返回的 platform 大小写不一致）