Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resume play after load complete. #329

Merged
merged 2 commits into from Aug 20, 2020
Merged

resume play after load complete. #329

merged 2 commits into from Aug 20, 2020

Conversation

xianyinchen
Copy link
Contributor

@xianyinchen xianyinchen commented Aug 19, 2020

No description provided.

this._playing = true;
}
else {
cc.warn(`Video play function only invalid after loading complete.`);
Copy link
Contributor

@jareguo jareguo Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only available when loaded.

invalid 是不可用才对

Copy link
Contributor

@jareguo jareguo Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得这里应该等加载后自动播放才对吧,其它平台不是这样的?

Copy link
Contributor Author

@xianyinchen xianyinchen Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实应该这样处理,我重新修改了

PPpro
PPpro approved these changes Aug 20, 2020
@holycanvas holycanvas merged commit c3a24af into cocos-creator-packages:v2.4.3-release Aug 20, 2020
@xianyinchen xianyinchen changed the title forbid play call when video data loading and throw a warning. resume play after load complete. Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants