Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when no camera render EidtBox, VIdeoPlayer, WebView on native platform #332

Merged
merged 2 commits into from Aug 28, 2020

Conversation

PPpro
Copy link
Contributor

@PPpro PPpro commented Aug 24, 2020

@PPpro
Copy link
Contributor Author

PPpro commented Aug 24, 2020

@holycanvas

@PPpro
Copy link
Contributor Author

PPpro commented Aug 24, 2020

@yongminghuang can migrate this bug fix into the runtime adapter repo

@@ -269,6 +269,9 @@
this._h = node._contentSize.height;

let camera = cc.Camera.findCamera(node)._camera;
if (!camera) {
return;
Copy link
Contributor

@jareguo jareguo Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should validate camera at the beginning, just after line 253

Copy link
Contributor Author

@PPpro PPpro Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@holycanvas holycanvas merged commit f78ead1 into cocos-creator-packages:v2.4.3-release Aug 28, 2020
@PPpro PPpro deleted the 243_editbox branch Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants