New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertex exceed 65535 error and dragonbones leak #1669

Merged
merged 8 commits into from Feb 12, 2019

Conversation

Projects
None yet
2 participants

sunnylanwanjun added some commits Jan 28, 2019

@sunnylanwanjun sunnylanwanjun changed the title Fix vertex exceed 65535 error and db leak Fix vertex exceed 65535 error and dragonbones leak Feb 12, 2019

, _vb(INIT_VB_BUFFER_SIZE)
, _vertexFormat(vertexFormat)
{
_vb.setMaxSize(MAX_VB_BUFFER_SIZE);

This comment has been minimized.

@pandamicro

pandamicro Feb 12, 2019

Member

其实是 IB Buffer 超限了,如果有一种 vertex format 的格式很简单,一个 vertex 只占用两三个 float,那么这个 MAX_VB_BUFFER_SIZE 其实就错了,所以这里要考虑全面一些

{
_objects.push_back(object);
}
_objectsMap[object] = true;

This comment has been minimized.

@pandamicro

pandamicro Feb 12, 2019

Member

哪里会检查这个 map 里面存储的 boolean 标记?有什么作用?

This comment has been minimized.

@pandamicro

pandamicro Feb 12, 2019

Member

加一句注释吧,暂时先不处理

This comment has been minimized.

@sunnylanwanjun

sunnylanwanjun Feb 12, 2019

Author Contributor

加了

@pandamicro pandamicro merged commit 5507ec6 into cocos-creator:v2.0-release Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment