Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential crash on websocket for lifecycle sync issues #1681

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@drelaptop
Copy link
Contributor

drelaptop commented Feb 18, 2019

  • JSDelegate 保存的 js object 是临时对象时,可能被 GC,造成回调时 crash
  • 一个特例是 runtime 的 ws 测试例,在 iOS 上的表现,cocos2d-x/cocos-game-client#763

@drelaptop drelaptop requested a review from sunnylanwanjun Feb 18, 2019

@drelaptop

This comment has been minimized.

Copy link
Contributor Author

drelaptop commented Feb 18, 2019

JS & C++ 生命周期同步的问题,麻烦 review ~ @sunnylanwanjun

@drelaptop drelaptop merged commit a5ccce5 into cocos-creator:v2.0-release Feb 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.