Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smart pointers to hold references of global Application::_scheduler #1732

Merged

Conversation

Projects
None yet
4 participants
@PatriceJiang
Copy link
Contributor

commented Apr 25, 2019

修复"Win32 关闭运行窗口时出现报错"

程序结束时 Application::_scheduler先于Downloader释放, 导致内存错误. 使用std::weak_ptr保证引用的正确性.

PatriceJiang added some commits Apr 25, 2019

@PatriceJiang

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@minggo pls review if you are available.

@PatriceJiang PatriceJiang changed the title Use smart pointer to hold reference of global Application::_scheduler Use the smart pointers to hold references of global Application::_scheduler Apr 25, 2019

@PatriceJiang PatriceJiang changed the title Use the smart pointers to hold references of global Application::_scheduler Use smart pointers to hold references of global Application::_scheduler Apr 25, 2019

@minggo

minggo approved these changes Apr 25, 2019

@knoxHuang

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@jareguo jareguo merged commit 7f86b1c into cocos-creator:v2.1.1-release Apr 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.