Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed add stage item #1897

Merged
merged 2 commits into from Oct 25, 2019
Merged

Conversation

@2youyou2
Copy link
Contributor

2youyou2 commented Oct 23, 2019

@@ -177,24 +179,21 @@ void BaseRenderer::render(const View& view, const Scene* scene)
stageItem.uniforms = item->uniforms;
stageItem.definesKeyHash = item->definesKeyHash;

stageItems.push_back(stageItem);

This comment has been minimized.

Copy link
@2youyou2

2youyou2 Oct 23, 2019

Author Contributor

每个 stage 应该用单独的 std::vector

@@ -128,6 +129,7 @@ class BaseRenderer : public Ref
RecyclePool<DrawItem>* _drawItems = nullptr;
RecyclePool<StageInfo>* _stageInfos = nullptr;
RecyclePool<View>* _views = nullptr;
RecyclePool<StageItem>* _stageItems = nullptr;

This comment has been minimized.

Copy link
@holycanvas

holycanvas Oct 23, 2019

Contributor

貌似没看到有用这个_stageItems的地方,是用在了其他地方了么?

This comment has been minimized.

Copy link
@2youyou2

2youyou2 Oct 23, 2019

Author Contributor

多余的,漏删了

@jareguo jareguo merged commit 02d8dff into cocos-creator:v2.2.2 Oct 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.