Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spine crash when resource missing #1745

Merged

Conversation

@sunnylanwanjun
Copy link
Contributor

@sunnylanwanjun sunnylanwanjun commented May 23, 2019

issue: https://github.com/cocos-creator/2d-tasks/issues/1452
关联pr:cocos-creator-packages/jsb-adapter#137
当skeleton资源解析失败,或资源获取失败时,只是返回,而不是crash

@minggo
Copy link
Contributor

@minggo minggo commented May 23, 2019

现在的 Spine runtime 是我们自己维护还是用官网的?如果是用官网的话,那么最好也向官网提交 PR,不然后续不好升级。

@sunnylanwanjun
Copy link
Contributor Author

@sunnylanwanjun sunnylanwanjun commented May 23, 2019

现在的 Spine runtime 是我们自己维护还是用官网的?如果是用官网的话,那么最好也向官网提交 PR,不然后续不好升级。

是的,我有给官方提pr的,不过他们好像一直没动静。

@jareguo jareguo merged commit 626cf1e into cocos-creator:v2.0.10-release May 23, 2019
1 check passed
@jareguo
Copy link
Member

@jareguo jareguo commented May 23, 2019

修复原生平台上 Spine 资源获取或解析失败时会引起崩溃的问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants