fix spine binary data read issue. #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianyinchen
changed the title
minggo
reviewed
Jan 27, 2022
| auto _scaleX = readFloat(input); | ||
| auto _scaleY = readFloat(input); | ||
| auto _width = readFloat(input); | ||
| auto _height = readFloat(input); |
minggo
reviewed
Jan 27, 2022
|
|
||
| RegionAttachment *region = _attachmentLoader->newRegionAttachment(*skin, String(name), String(path)); | ||
| if (region == NULL){ | ||
| return NULL; |
There was a problem hiding this comment.
这个不做修改，保持与源文件的风格一样，如果要整改，应该整个 spine 扩展一起做下优化
minggo
reviewed
Jan 27, 2022
| region->_scaleY = _scaleY; | ||
| region->_width = _width * _scale; | ||
| region->_height = _height * _scale; | ||
| region->_color = color; |
zhakesi
approved these changes
Feb 8, 2022
minggo
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cocos-creator/3d-tasks/issues/10982